This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] xen-unstable warn_on in msi.c:636

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] xen-unstable warn_on in msi.c:636
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Thu, 30 Jun 2011 14:31:22 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 30 Jun 2011 06:32:03 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Yt6S9/EnO8sVxtJhpgEH2zPUgA+pJlz67hdYXeeYRk8=; b=slMIVpgvZkc+ernfhNN2FbVrb02BJMnzHxPRTObArVpl0tPjJXzrjDW27xPVfPsUsE IBEhzCXBbAAbQlDjFii5n6tzBX2dorelDVGBdRK8zmpOF1tyZ5pqt78ypNcKDdpt2Nnb Qv9YvkBnFHz6ZAth391aokfUte4crrAZkHKGo=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E0C8575020000780004B52E@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110630091700.GA8582@xxxxxxxxx> <4E0C5E4F020000780004B40B@xxxxxxxxxxxxxxxxxxxx> <BANLkTimc_WfPTpNGKk0s_EnZzRq75RBrmg@xxxxxxxxxxxxxx> <4E0C8575020000780004B52E@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, Jun 30, 2011 at 1:17 PM, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>>>> On 30.06.11 at 14:03, George Dunlap <George.Dunlap@xxxxxxxxxxxxx> wrote:
>> Olaf / Jan / all, what do you think of the attached patch, which
>> teaches the MSI code how to deal with 0 pbas?
> No, definitely not an option. They simply must not be zero. The
> problem just is that the BARs for virtual functions all read as zero
> (and the real value must be calculated from information from the
> PF's config space).

But at the moment it IS zero, and this "real value" is simply not
being calculated.

I realize this needs to be fixed the Right Way eventually, but at the
moment anyone who uses SRIOV will have a bunch of scary warnings which
they can't do anything about except ignore; and it's never a good idea
to condition people to ignore this kind of warning.

If the current situation is safe enough that fixing it is a low
priority, then it's safe enough to remove the warnings for the time
being.  If it's not safe enough to remove the warnings, then it's not
safe enough to leave and a fix needs to be a priority.


Xen-devel mailing list