On 06/28/11 14:57, Ian Jackson wrote:
Roger Pau Monné writes ("[Xen-devel] Patch for Xen 4.1.1 not working with LVM
volumes and pygrub on NetBSD"):
Xen 4.1.1 was incorrectly passing /dev/rmapper/vg-lvname to pygrub
(notice the r in front of mapper), when it should pass
/dev/mapper/rvg-lvname (add the r to the last file) when using NetBSD.
I've patched it to work correctly. I'm attaching a unified diff with
the patch made against Xen 4.1.1 (it's a really simple modification).
Thanks, I have applied your patch.
Next time, though, can you please be sure to add a Signed-off-by line,
to signify your certification in accordance with the Developer's
Certificate of Origin ? In this case I'll go ahead as it's only a
The signed-off-by lines are not common in the BSD world:
From Documentation/SubmittingPatches in the Linux kernel tree:
Developer's Certificate of Origin 1.1
Xen kernel != Linux kernel
If you want people to follow the Linux kernel guidelines this should
be explicitely documented somewhere easy to find even for someone not
familiar with the Linux community.
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
Xen-devel mailing list