This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: Konrad devel/next-3.0, pci-passthrough not working:

To: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: Konrad devel/next-3.0, pci-passthrough not working: Error: pci: PCI Backend and pci-stub don't own device
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 22 Jun 2011 10:28:13 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Wed, 22 Jun 2011 07:29:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <717240289.20110622161313@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <437780710.20110621154126@xxxxxxxxxxxxxx> <20110621141355.GA15205@xxxxxxxxxxxx> <1918309554.20110621171142@xxxxxxxxxxxxxx> <20110621170525.GA10328@xxxxxxxxxxxx> <1284512453.20110621210229@xxxxxxxxxxxxxx> <20110622140022.GB5574@xxxxxxxxxxxx> <717240289.20110622161313@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
> >> >> module name: xen_pciback
> >> >> driver:      pciback
> >> >> 
> >> >> Quite a mix of names, and different use of minus and underscore.
> >> 
> >> > Hmm, you are a right. I somehow I thought I backed up the patch that
> >> > used the wrong name (well, not wrong but just incorrect).
> >> 
> >> So if I understand you correct you will revert the driver name from 
> >> xen-pciback to pciback, so no xen change is needed ?
> > So this patch:
> > f3fc28d52f42220bcce8c2fed12aef2a88c9fadc
> >     xen/pciback: revert the name of the PCI driver to 'pciback'.
> > should have done the trick but I am not seeing it in the
> > devel/xen-pciback-0.6.. Aha! I forgot to push the branch up to 
> > git.kernel.org.
> > Before I do that, can you cherry-pick that one please and tell
> > me if it works? If it does I will stick 'Reported-by' and 'Tested-by'
> > on the patch if you are OK with that.
> And were exactly do i cherry pick that from ? :-) since you say you haven't 
> pushed it :p

<smacks his head>
> If you can attach the patch i will test it right away, sticking the reported 
> and tested-by is fine !

See attached or inline:

commit f3fc28d52f42220bcce8c2fed12aef2a88c9fadc
Author: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date:   Wed Apr 20 16:06:47 2011 -0400

    xen/pciback: revert the name of the PCI driver to 'pciback'.
    At least until the toolstack catches up and it will be able
    to handle 'xen_pciback'.
    This means we have these directories in sysfs:
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

diff --git a/drivers/pci/xen-pciback/pci_stub.c 
index d802261..aec214a 100644
--- a/drivers/pci/xen-pciback/pci_stub.c
+++ b/drivers/pci/xen-pciback/pci_stub.c
@@ -848,7 +848,9 @@ static struct pci_error_handlers xen_pcibk_error_handler = {
 static struct pci_driver xen_pcibk_pci_driver = {
-       .name = DRV_NAME,
+       /* The name should be xen_pciback, but until the tools are updated
+        * we will keep it as pciback. */
+       .name = "pciback",
        .id_table = pcistub_ids,
        .probe = pcistub_probe,
        .remove = pcistub_remove,

Attachment: pciback.patch
Description: Text Data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>