This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 02 of 22] tools: merge several bitop functions in

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 02 of 22] tools: merge several bitop functions into xc_bitops.h
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Tue, 21 Jun 2011 19:17:46 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Jun 2011 10:18:51 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1308676667; l=1337; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=3wtmC9koeqcpBkGNN+Pb/rArfhs=; b=kOiGPGSq8E3Oy15M5ANk6RhxTdnIvNJNkEpopup1sQqI9XfcmG9atI7Y1kQBo/py+8/ 0CS/22RWLvi1BYgTYVs9kQhIe5jl2UtqOQo1UV6TDH/bwc8I5JctoRR36ksJErXeA2f5A 68h6T2Ox1LngN7DAeg8YojN2h1L/EftpP8o=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19968.50159.462491.332465@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307697169@xxxxxxxxxxxx> <9476d85932e5eb8f1e7c.1307697171@xxxxxxxxxxxx> <19968.50159.462491.332465@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-12-30)
On Tue, Jun 21, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 02 of 22] tools: merge several bitop 
> functions into xc_bitops.h"):
> > tools: merge several bitop functions into xc_bitops.h
> This seems to break the stubdom build, I'm afraid.

> xc_domain_save.c:30:23: error: xc_bitops.h: No such file or directory

(I just ran 'make tools' to verify my changes, not make or 'make stubdom')

Why are the symlinks not updated? I can not reproduce the failure in a
fresh build.  xc_domain_save.c references other files like xc_private.h
in the same directory. 
So I think the bug is not strictly in my change, but may point to some
other bug.

Maybe its related to the issue I ran often while working on this series:
Repeated hg qpush/qpop with a patch that adds a new header or removes an
existing one, does not update the .*.d file. As a result, make fails
because there is 'no rule to make target foo.h'. The only way is to do a
make clean in these directories to remove the .*.d files.

time passes.

I can reproduce it now with a fresh build without patches, then apply
just this patch and run make again.
First tools/xenpaging/ fails because there is now 'no rule to make
target bitops.h'. A 'rm tools/xenpaging/.*.d ; make' fixes it.
Now it fails as you describe.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>