This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] no-fork option for tapdisk2 debugging

To: Philipp Hahn <hahn@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] no-fork option for tapdisk2 debugging
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 21 Jun 2011 15:29:20 +0100
Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Jun 2011 07:29:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201106211529.39113.hahn@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <201106211529.39113.hahn@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Philipp Hahn writes ("[Xen-devel] [PATCH] no-fork option for tapdisk2 
> For debugging tapdisk2 it would be nice if forking into the background could 
> be disabled by passing some command line argument. The attached patch adds 
> such an option (-n).

This seems reasonable.

> The second patch re-indents four un-changed lines.

That should be folded into the first patch, which otherwise leaves the
indentation wrong.

> It would be nice if this could be included into the source core repository.

Also, you to add a Signed-off-by line to your patch to signify its
copyright status (see below).


>From Documentation/SubmittingPatches in the Linux kernel tree:
        Developer's Certificate of Origin 1.1
        By making a contribution to this project, I certify that:
        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or
        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or
        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

Xen-devel mailing list