[Xen-devel] Re: [PATCH 03 of 22 v2] xenpaging: add xs_handle to struct xenpaging

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2011-06-20 at 10:58 +0100, Olaf Hering wrote:
> A xs_handle is currently used in the xc_mem_paging_flush_ioemu_cache()
> function and will be used by a subsequent patch.
> Add it to struct xenpaging.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Looks good. Only one quibble...

> @@ -277,6 +288,9 @@ static int xenpaging_teardown(xenpaging_
>      }
>      paging->mem_event.xce_handle = NULL;
>      
> +    /* Close connection to xenstore */
> +    xs_daemon_close(paging->xs_handle);
> +

...xs_close() please.

Other than that:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Cheers,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel