This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Possible bug in XendConfig.py

To: Alexander Fittkau <alexander.fittkau@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Possible bug in XendConfig.py
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 20 Jun 2011 15:31:07 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 20 Jun 2011 07:31:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DFB34B5.3080507@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4DFB34B5.3080507@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Alexander Fittkau writes ("[Xen-devel] Possible bug in XendConfig.py"):
> While poking around in various Xend*.py sources (Xen 4.0.1, Debian
> Squeeze) I discovered a possible Bug in XendConfig.py. More precisely in
> the method to_sxp of the class XendConfig. It exposes an optional
> parameter "domain=None". But further checks regarding the presence of
> this parameter check against member-functions such as domain.getDomid()
> or domain._stateGet() which raise an Exception if the parameter is
> 'None'. The docstring states that this parameter is optional, but
> further handling of it either suggest it is not, or the checks are
> mistakenly made against methods of 'domain' instead of domain itself.

I don't think anyone here is really capable of answering these
questions.  Are you asking because xend is malfunctioning for you (eg,
producing stack traces) ?  Or just because you happened to see this
apparent anomaly in the code ?

If the latter, then I'm afraid we're not likely to fix it.  xend is on
the way out; certainly, it is deprecated in xen-unstable.

> Is this patched in newer versions, can I just add the correct checks or 
> will this break something somewhere else?

If you have a change which makes things work for you, which break
without your patch, we're certainly interested in that.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>