 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 1 of 4] fix state
Zhigang Wang writes ("[Xen-devel] [PATCH 1 of 4] fix state"):
> - else if [[ "$1" =~ '(name' ]]; then
> + else if [[ "$1" =~ $name_re ]]; then
This is really shockingly ugly. What would be wrong with using case ?
Since this is a bash-specific script already, we can use
${..#...} ${..##...} ${..%...} ${..%%...} too.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] add a way to disable xen's udev script., Ian Jackson |
|---|---|
| Next by Date: | [Xen-devel] Re: [PATCH] libxl: initialize domid to 0 in libxl__create_stubdom, Ian Jackson |
| Previous by Thread: | [Xen-devel] [PATCH 1 of 4] fix state, Zhigang Wang |
| Next by Thread: | [Xen-devel] [PATCH 2 of 4] fix not functional eval, Zhigang Wang |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
