WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 7 of 7] KEXEC: correctly revert x2apic state when

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 7 of 7] KEXEC: correctly revert x2apic state when kexecing [Reformatted, v2]
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Wed, 15 Jun 2011 17:03:59 +0100
Cc: Jan, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Wed, 15 Jun 2011 09:08:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1308153010.17937.212.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DF896CC0200007800047532@xxxxxxxxxxxxxxxxxxxx> <4DF87DF1.4000000@xxxxxxxxxx> <4DF8A218020000780004756C@xxxxxxxxxxxxxxxxxxxx> <4DF88B1B.6090503@xxxxxxxxxx> <4DF8A942020000780004758A@xxxxxxxxxxxxxxxxxxxx> <4DF89EB2.3000609@xxxxxxxxxx> <4DF8D2A7.2070405@xxxxxxxxxx> <1308153010.17937.212.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Lightning/1.0b2 Thunderbird/3.1.10

On 15/06/11 16:50, Ian Campbell wrote:
> On Wed, 2011-06-15 at 16:41 +0100, Andrew Cooper wrote:
>> Tweaked the patch to prevent IOMMU_WAIT_OP panicking on the kexec path. 
>> Unfortunately, this has to rely on the kexecing variable.
>>
>> As with the other hacks in this patch, I cant see a better way of
>> solving the problem.
>>
>
>> @@ -99,8 +100,9 @@ do {                                    
>>          if ( cond )                                 \
>>              break;                                  \
>>          if ( NOW() > start_time + DMAR_OPERATION_TIMEOUT )      \
>> -            panic("%s:%d:%s: DMAR hardware is malfunctional\n", \
>> -                  __FILE__, __LINE__, __func__);                \
>> +            if ( !kexecing )                                    \
>> +                panic("%s:%d:%s: DMAR hardware is malfunctional\n",\
>> +                      __FILE__, __LINE__, __func__);            \
>>          cpu_relax();                                            \
>>      }                                                           \
>>  } while (0)
> I think you want an "else break" here to cause it to struggle onwards
> rather than the infinite loop you get otherwise.
>
> Ian
Yep - Fixed and reformatted against staging again.

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Attachment: kexec-prevent-panic.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel