WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcend

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen Transcendent Memory only if Cleancache is enabled
From: Nikanth Karthikesan <nikanth@xxxxxxxxxx>
Date: Tue, 14 Jun 2011 14:13:07 +0530
Cc: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Tue, 14 Jun 2011 01:44:03 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1308040998; bh=2M2phiyM2aDtQfPrtNHVmzX/Rco=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=DMGn2JBZE/yUrJnPbrXGjc8WOSjEyPlvUMKkYdGLmHjG0lZqFewREpdEpt/dYyVO6 V+mysrvGD+uF+J/cE15qg==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:subject:from:to:cc:in-reply-to:references :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=4EZflPEVhj8zjyFIysKzsBPWV9PcG8fXjRXEmkKHP6Q=; b=t8ZQrbMNQ07Fnzg8oXGgZzR7RcIENAKJwoRXD1Z58BTByGzo8zNYaL40oQiwWTkpMD OlxSffc+yJ13fylOgt6w==
Domainkey-signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=Fisvl81DhXpZG9u6Zg0S3fwlFcGw8rzQQ9D81IHu1yuvNqAX1MD4FvqZTkhRW6dHqU qQl6SF9IpA15AmtWEk6A==
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DF737EC0200007800046F1F@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1307696223.28682.21.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <62886fcb-651d-4529-98a1-58443dd83e9e@default> <4DF737EC0200007800046F1F@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2011-06-14 at 09:29 +0100, Jan Beulich wrote:
> >>> On 13.06.11 at 16:58, Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> wrote:
> >>  +obj-$(CONFIG_CLEAN_CACHE)        += tmem.o
> > 
> > Hi Nikanth --
> > 
> > Thanks for the suggested patch.  However, tmem.c works with both
> > cleancache and frontswap... the shim in place only works with
> > cleancache but there is a posted patch for it to work with
> > frontswap as well.  So your patch would just need to be
> > redone when frontswap is included soon.
> > 
> > BUT... is there a way to do an inclusive-or operation
> > in a Makefile?... something like this (though I know this
> > exact syntax won't work)...
> > 
> > obj-($CONFIG_CLEANCACHE||$CONFIG_FRONTSWAP)
> 
> You can specify the same object more than once, i.e.
> 
> obj-$(CONFIG_CLEAN_CACHE)     += tmem.o
> obj-$(CONFIG_FRONTSWAP)       += tmem.o
> 

Cool!

So, can this patch be merged then? It would be easy to patch for
frontswap, in the frontswap patchset.

Thanks
Nikanth

> Jan
> 
> > 
> > Thanks,
> > Dan
> > 
> > Thanks... for the memory!
> > I really could use more / my throughput's on the floor
> > The balloon is flat / my swap disk's fat / I've OOM's in store
> > Overcommitted so much
> > (with apologies to Bob Hope)
> > 
> >> -----Original Message-----
> >> From: Nikanth Karthikesan [mailto:nikanth@xxxxxxxxxx] 
> >> Sent: Friday, June 10, 2011 2:57 AM
> >> To: xen-devel@xxxxxxxxxxxxxxxxxxx 
> >> Cc: Jeremy Fitzhardinge; Konrad Rzeszutek Wilk
> >> Subject: [Xen-devel] [PATCH] xen-tmem: Build cleancache shim to Xen 
> > Transcendent Memory only if
> >> Cleancache is enabled
> >> 
> >> xen-tmem: Build cleancache shim to Xen Transcendent Memory only if 
> > Cleancache is enabled
> >> 
> >> Fix compilation warning
> >> 
> >> drivers/xen/tmem.c: In function ‘xen_tmem_init’:
> >> drivers/xen/tmem.c:246: warning: unused variable ‘old_ops’
> >> drivers/xen/tmem.c: At top level:
> >> drivers/xen/tmem.c:234: warning: ‘tmem_cleancache_ops’ defined but not used
> >> 
> >> Signed-off-by: Nikanth Karthikesan <nikanth@xxxxxxxxxx>
> >> 
> >> ---
> >> 
> >> Index: linux-2.6/drivers/xen/Makefile
> >> ===================================================================
> >> --- linux-2.6.orig/drivers/xen/Makefile    2011-06-10 13:42:18.521140982 
> >> +0530
> >> +++ linux-2.6/drivers/xen/Makefile 2011-06-10 13:44:50.110986353 +0530
> >> @@ -1,6 +1,6 @@
> >>  obj-y     += grant-table.o features.o events.o manage.o balloon.o
> >>  obj-y     += xenbus/
> >> -obj-y     += tmem.o
> >> +obj-$(CONFIG_CLEAN_CACHE) += tmem.o
> >> 
> >>  nostackp := $(call cc-option, -fno-stack-protector)
> >>  CFLAGS_features.o                 := $(nostackp)
> >> Index: linux-2.6/drivers/xen/tmem.c
> >> ===================================================================
> >> --- linux-2.6.orig/drivers/xen/tmem.c      2011-06-10 12:19:14.522391890 
> >> +0530
> >> +++ linux-2.6/drivers/xen/tmem.c   2011-06-10 13:45:42.500984200 +0530
> >> @@ -247,7 +247,6 @@
> >> 
> >>    if (!xen_domain())
> >>            return 0;
> >> -#ifdef CONFIG_CLEANCACHE
> >>    BUG_ON(sizeof(struct cleancache_filekey) != sizeof(struct tmem_oid));
> >>    if (tmem_enabled && use_cleancache) {
> >>            char *s = "";
> >> @@ -257,7 +256,6 @@
> >>            printk(KERN_INFO "cleancache enabled, RAM provided by "
> >>                             "Xen Transcendent Memory%s\n", s);
> >>    }
> >> -#endif
> >>    return 0;
> >>  }
> >> 
> >> 
> >> 
> >> 
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> >> http://lists.xensource.com/xen-devel 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx 
> > http://lists.xensource.com/xen-devel 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel