Re: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 16:25 +0800 on 09 Jun (1307636725), Eddie Dong wrote:
> +    /* pass through MSRs */
> +    case MSR_IA32_VMX_MISC:
> +    case MSR_IA32_VMX_CR0_FIXED0:
> +    case MSR_IA32_VMX_CR0_FIXED1:
> +    case MSR_IA32_VMX_CR4_FIXED0:
> +    case MSR_IA32_VMX_CR4_FIXED1:
> +    case MSR_IA32_VMX_VMCS_ENUM:
> +        gdprintk(XENLOG_WARNING, "VMX MSR %x not fully supported yet.\n", 
> msr);

Are you planning to fix this before checking in this series?  I'm pretty
sure that at least MSR_IA32_VMX_VMCS_ENUM should be trivial, since you
define your own VMCS format. 

Tim.

> +        break;
> +
> +    default:
> +        r = 0;
> +        break;
> +    }
> +
> +    *msr_content = data;
> +    return r;
> +}
> +
> +int nvmx_msr_write_intercept(unsigned int msr, u64 msr_content)
> +{
> +    /* silently ignore for now */
> +    return 1;
> +}
> +
>  void nvmx_idtv_handling(void)
>  {
>      struct vcpu *v = current;
> diff -r 3189a3e6f05e -r 480cfcea095b xen/include/asm-x86/hvm/vmx/vvmx.h
> --- a/xen/include/asm-x86/hvm/vmx/vvmx.h      Thu Jun 09 16:24:09 2011 +0800
> +++ b/xen/include/asm-x86/hvm/vmx/vvmx.h      Thu Jun 09 16:24:09 2011 +0800
> @@ -163,6 +163,10 @@ int nvmx_handle_vmread(struct cpu_user_r
>  int nvmx_handle_vmwrite(struct cpu_user_regs *regs);
>  int nvmx_handle_vmresume(struct cpu_user_regs *regs);
>  int nvmx_handle_vmlaunch(struct cpu_user_regs *regs);
> +int nvmx_msr_read_intercept(unsigned int msr,
> +                                u64 *msr_content);
> +int nvmx_msr_write_intercept(unsigned int msr,
> +                                 u64 msr_content);
>  
>  void nvmx_update_exec_control(struct vcpu *v, u32 value);
>  void nvmx_update_secondary_exec_control(struct vcpu *v,
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel