This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] OCaml tools: ask compiler for correct library pa

To: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] OCaml tools: ask compiler for correct library path
From: Mike McClurg <mike.mcclurg@xxxxxxxxxx>
Date: Wed, 8 Jun 2011 11:53:52 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jonathan, Ludlam <Jonathan.Ludlam@xxxxxxxxxxxxx>
Delivery-date: Wed, 08 Jun 2011 03:57:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110607202153.GA9629@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DEE5FC1.4040609@xxxxxxxxxx> <20110607202153.GA9629@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux i686; rv:2.0b13pre) Gecko/20110314 Thunderbird/3.3a3
On 07/06/11 21:21, Tim Deegan wrote:

At 18:28 +0100 on 07 Jun (1307471313), Mike McClurg wrote:
From: Mike McClurg<mike.mcclurg@xxxxxxxxxx>

OCaml libraries will live in /usr/local/ if the user compiles OCaml
from source. This patch asks the OCaml compiler where we should look
for libraries.
This patch edits the #include path, not the library path.  Are there
any ocaml support libraries that would require -L options to $(CC)?

Thank you for correcting me, I misspoke about the include path. No, there is no requirement to pass -L options on to $(CC). The -I option will be sufficient, and this patch removes hard coded file paths from the makefile.


NB: it may be that we should do the same thing for the NetBSD case,
but I don't have a BSD box to test this out.

Signed-off-by: Mike McClurg<mike.mcclurg@xxxxxxxxxx>

diff -r 37c77bacb52a -r ebc32e1f7f6f tools/ocaml/common.make
--- a/tools/ocaml/common.make   Mon May 23 17:38:28 2011 +0100
+++ b/tools/ocaml/common.make   Tue Jun 07 18:01:10 2011 +0100
@@ -9,7 +9,7 @@
  OCAMLYACC ?= ocamlyacc
  CFLAGS += -fPIC -Werror
-CFLAGS-$(CONFIG_Linux) += -I/usr/lib64/ocaml -I/usr/lib/ocaml
+CFLAGS-$(CONFIG_Linux) += -I$(shell ocamlc -where)
  CFLAGS-$(CONFIG_NetBSD) += -I/usr/pkg/lib/ocaml -fPIC
  OCAMLOPTFLAG_G := $(shell $(OCAMLOPT) -h 2>&1 | sed -n 's/^  *\(-g\) .*/\1/p')

Xen-devel mailing list

Xen-devel mailing list