This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 11 of 12] xenpaging: add watch thread to catch gu

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 11 of 12] xenpaging: add watch thread to catch guest shutdown
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Tue, 7 Jun 2011 21:07:20 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Jun 2011 12:08:14 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1307473641; l=1061; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=Oy8nr9EDLgpdv7lZ8J1NFXdQHGI=; b=krML0euJkCJl20kT2FKfHWyZhrYj21M+B+CQSrYc55Pih4yn2AIWB4Ra/nntn8ayOHT 923UkK0wZJDQD17iI1JlPlWPk6zQYiUN25TEqg3WCNMiO1PvYL7tuQ5ssoiYxAmsVbzTZ T8zILzqvmBK1ekHemy7S1/rmR2Bpnei5jyA=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1307442185.775.552.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307440382@xxxxxxxxxxxx> <9484d35ec6e802aa3727.1307440393@xxxxxxxxxxxx> <1307442185.775.552.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-12-30)
On Tue, Jun 07, Ian Campbell wrote:

> The correct way to watch for domain shutdown is to watch the special
> "@releaseDomain" node. IIRC this notifies you when _any_ domain has
> shutdown so you need to check for the domain you are actually interested
> in. Doing this also removes the need for the hacky extra xs_read_watch
> which you have -- which seems very racy to me and is almost certainly
> incorrect.

Thanks for the feedback, I have updated my patch to use this interface.

> Lastly I don't think you need a new thread for this, you can integrate
> the xs fd (from xs_fileno()) into your existing poll loop from
> xc_wait_for_event_or_timeout (which is a terrible name for a function
> which isn't in libxc, this should either be moved into the library or
> renamed depending on it's actual use cases. Same for the other xc_* in
> xenpaging...)

All of xc.c can be removed. If patches 1-10 are ok, can you apply them?

I will send another series to remove xc.c, which will also contain the
changes from patch 11 and 12.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>