This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxl: use '-name' instead of deprecated '-domai

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: use '-name' instead of deprecated '-domain-name' for device model
From: Wei Liu <liuw@xxxxxxxxx>
Date: Tue, 7 Jun 2011 20:11:24 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Jun 2011 05:12:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1106071250420.12963@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110607064842.GA8281@limbo> <alpine.DEB.2.00.1106071250420.12963@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, Jun 7, 2011 at 7:52 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Tue, 7 Jun 2011, Wei Liu wrote:
>> commit 6c744543757f0769e5a8f49ab0d8a01538357fbb
>> Author: Wei Liu <liuw@xxxxxxxxx>
>> Date:   Tue Jun 7 14:26:34 2011 +0800
>>     libxl: use '-name' instead of deprecated '-domain-name' for device model.
>>     This unifies upstream qemu and Xen's qemu-dm startup option.
>>     Signed-off-by: Wei Liu <liuw@xxxxxxxxx>
>> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
>> index 47a51c8..d53a20d 100644
>> --- a/tools/libxl/libxl_dm.c
>> +++ b/tools/libxl/libxl_dm.c
>> @@ -95,7 +95,7 @@ static char ** 
>> libxl__build_device_model_args_old(libxl__gc *gc,
>>                        "-d", libxl__sprintf(gc, "%d", info->domid), NULL);
>>      if (info->dom_name)
>> -        flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
>> +        flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
>>      if (info->vnc) {
>>          char *vncarg;
> considering that libxl__build_device_model_args_old is only meant to be
> used with the old qemu-xen that we are not going to upgrade anymore, I
> don't think it is worth to try to update its command line options.

Well, the device_model_{override,version} are not working for pv now.
So I consider this patch a workaround for using upstream qemu as pure
pv backend.

I'm still waiting for IanJ's re-factoring of libxl. Hope that could
get a better implementation.

Xen-devel mailing list