This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 07 of 20] Emulation of guest vmptrld

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 07 of 20] Emulation of guest vmptrld
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Tue, 7 Jun 2011 09:48:15 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Delivery-date: Mon, 06 Jun 2011 18:50:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110603084212.GR5098@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307005033@xxxxxxxxxxxxxxxxxxxx> <4dad232d7fc3bd62979a.1307005040@xxxxxxxxxxxxxxxxxxxx> <20110602144553.GJ5098@xxxxxxxxxxxxxxxxxxxxxxx> <1A42CE6F5F474C41B63392A5F80372B256199898@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110603084212.GR5098@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwhyignQjipVAjgSrWwnXQJDdaHtQC6raqw
Thread-topic: [Xen-devel] [PATCH 07 of 20] Emulation of guest vmptrld
> > > (While I'm looking at this code, this function is quite ugly.  Why have
> > > a single function if you're going to duplicate its contents anyway?)
> >
> > ??? We don't know fi guest changed the bitmap, so we have to check each
> time.
> I think I wasn't clear.  The logic is fine, I was just cavilling about
> coding style.  You have some code that's basically
I see, yes it is better and fixed.

Thx, Eddie

Xen-devel mailing list