This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Add xl domUs default configuration file

On Mon, 2011-06-06 at 16:14 +0100, Stefano Stabellini wrote:
> On Mon, 6 Jun 2011, Ian Campbell wrote:
> > On Mon, 2011-06-06 at 14:30 +0100, Stefano Stabellini wrote:
> > > What do you mean? Xl already provides defaults for almost
> > > everything...
> > > In any case the idea of a default xl config file is not bad.
> > 
> > Wouldn't something need to read this file for it to be controlling the
> > defaults? Would that "something" replace the libxl_*_init and other
> > places where the library provides a default? How does this work with
> > other toolstacks using libxl?
> > 
> > Or is this intended to be an xl version of the existing xmexample.*
> > files? In which case calling it xlexample.* might help people towards
> > this conclusion. Also avoiding the term "default" would help -- a
> > default is different to an example.
> After Fabio's reply I think that the real intention was to introduce a
> new config file to set the default value of most options, across
> multiple VMs, in fact replacing all the libxl_*_init functions.
> The xend equivalent would be xend-config.sxp.
> I think that could probably be done in xl.conf, it is an xl thing more
> than a libxl thing. Basically we need to run the parser twice on
> xl.conf first and then on the VM config file.
> > > > +# Define the disk devices you want the domain to have access to,
> > > and
> > > > +# what you want them accessible as.
> > > > +# For example can be put here a default installation cd.
> > > > +# disk = [ 'tap2:aio:/var/images/min-el3-i386.img,hdc:cdrom,r' ]
> > > 
> > > tap2 shouldn't be the default, probably is better to specify just
> > > file: here
> > 
> > If this file really is supposed to contain defaults and not examples
> > then I don't think a default makes sense for this kind of setting.
> Yes, indeed. I think it should just be an example.

If this is really a file full of defaults then only things which have a
sensible non-Null default value that people might want to change should
be in there. Disk does not fall into this and neither do many of the
other settings in the proposed patch. 

A file full of examples should be separate.


Xen-devel mailing list