This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 8/9] xl: xl block-attach -N (dry run) option

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 8/9] xl: xl block-attach -N (dry run) option
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 3 Jun 2011 14:00:33 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 03 Jun 2011 06:01:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19944.49800.946998.730440@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1307037346-31251-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-2-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-3-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-4-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-5-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-7-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-8-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307037346-31251-9-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1307098008.775.368.camel@xxxxxxxxxxxxxxxxxxxxxx> <19944.49800.946998.730440@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-06-03 at 12:16 +0100, Ian Jackson wrote:
> Just the entire structure.
> JSON would be a good concrete syntax.
> If we had a competent JSON pretty-printer it would do as the
> human-readable output too.

Should be pretty easy. QMP support in libxl is also going to require a
JSON library (for internal use by libxl, not exposed to libxl users),
which hopefully has functions which make the pretty part trivial.

>   We shouldn't be encouraging XML :-).


> > What do you think? (I think I lean towards the final option, unless a
> > single hardcoded syntax is thought to be sufficient).
> The prototype you suggest is not sufficient because field members may
> be structures, so the whole thing needs to be recursive.  If you want
> reasonable output from a recursive pretty-printer you need to pass an
> indent level etc.

Oh yeah. Add more params to callback as necessary ;-)


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>