This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [xen-unstable bisection] complete test-i386-xcpkern-i386

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [xen-unstable bisection] complete test-i386-xcpkern-i386-pv
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 3 Jun 2011 11:49:48 +0100
Cc: "W. Michael Petullo" <mike@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "keir@xxxxxxx" <keir@xxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 03 Jun 2011 03:50:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1307093013.775.328.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1QSQCt-0002a9-Jx@xxxxxxxxxxxxxxxxxxx> <1307093013.775.328.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable bisection] complete 
> On Fri, 2011-06-03 at 09:58 +0100, Ian Jackson wrote:
> >       tools/hotplug: support vif-post.d hook arrangements
> >       
> >       New feature: you can drop hook scripts into
> >        /etc/xen/scripts/vif-post.d/*.hook
> >       
> >       Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >       Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I had a suspicion it might be that ...

> That message comes from the "trap sigerr ERR". The hotplug script has
> "set -e" so some command has failed.

It's a shame that we don't get the stderr output under xend.  Still,
let's not try to fix that ...

> My guess is that when there are no hooks at all this:
>     for f in /etc/xen/scripts/${1}-${2}.d/*.hook; do
>         [ -x "$f" ] && . "$f"
>     done
> expands into a literal
>       [ -x ".....*.hook" ] && . "..... *.hook"
> and since ....*.hook doesn't exist the overall result of this expression
> is failure. The same would happen for any *.hook which wasn't
> executable.


mariner:~> bash -ec 'trap "echo e" ERR; false && echo a; echo b'
mariner:~> dash -ec 'for f in /etc/xen/scripts/${1}-${2}.d/*.hook; do [ -x "$f" 
] && . "$f"; done; echo ok'
mariner:~> ls /etc/xen/scripts
/bin/ls: cannot access /etc/xen/scripts: No such file or directory

set -e and the ERR trap don't apply to && and || lists at all.  This
is arguably a specification bug.

> Perhaps the following helps?

I think we need more diagnosis.  I'll investigate.


Xen-devel mailing list