RE: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure
> At 16:57 +0800 on 02 Jun (1307033853), Eddie Dong wrote:
> > + case MSR_IA32_VMX_PINBASED_CTLS:
> > +#define REMOVED_PIN_CONTROL_CAP (PIN_BASED_PREEMPT_TIMER)
> > + rdmsr(msr, eax, edx);
> > + data = edx;
> > + data = (data << 32) | eax;
> > + break;
> You don't actually mask the value here.
> BTW, I don't really like defining all these REMOVED_* macros, each
> of which is used only once a few lines from the definition (here and
> elsewhere in the series). It just adds clutter for no benefit.
OK, removed to be in code itself.
Xen-devel mailing list