This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] libxl: basic support for virtio disk

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] libxl: basic support for virtio disk
From: Wei Liu <liuw@xxxxxxxxx>
Date: Fri, 3 Jun 2011 09:22:52 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 02 Jun 2011 18:24:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19943.46165.598420.601751@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTikbJFnVzqhnRy0=Vb0S=pgENDZ_qw@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1105271315270.12963@kaball-desktop> <BANLkTikM4AJz1jQi2v4vwM=EP7TEfUP-YQ@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1105271559170.12963@kaball-desktop> <BANLkTikA_Gw8fgQ4K_=eEg=jkx1TDKMSwQ@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1105311232300.12963@kaball-desktop> <BANLkTimiDzJLiM++TUR1ysksRjPYjBeu2Q@xxxxxxxxxxxxxx> <19942.17843.474817.123371@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTi=HZvj_7BqOAoiJ4cB99OZJmEoLTA@xxxxxxxxxxxxxx> <alpine.DEB.2.00.1106021555561.12963@kaball-desktop> <19943.46165.598420.601751@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, Jun 3, 2011 at 12:03 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] Re: [PATCH] libxl: basic support 
> for virtio disk"):
>> The limitation on the number of partitions is meaningless for virtio and
>> the limitation on the number of disks in arbitrary, as it is arbitrary
>> the current limitation on the number of scsi disks.
> So the code in libxl should accept any disk number that it can
> correctly format into an option to qemu, and allow qemu to deal with
> any resulting problems.
>> Device names like xvda1, xvda2, etc, are currently supported only with
>> PV guests.
> Currently the partition number is ignored.  Nonzero partitions should
> instead then be rejected.
>> There is no way to specify a single partition with HVM guests.
>> Considering that this patch is only meant for HVM guest, I think it is
>> correct to leave out the partition number.
> It should be checked, not ignored.
> Ian.

OK. Looks like the disk parsing code in libxl is going through a re-factoring.

I will get back to this patch when your re-factoring is done.


Xen-devel mailing list