This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] xl: print sxp on dry-run of create

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] xl: print sxp on dry-run of create
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Wed, 1 Jun 2011 13:51:48 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Wed, 01 Jun 2011 05:53:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.6.4
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1306932694 -3600
# Node ID 064a0d9f710a183928df7b8fa25f66f202c96abb
# Parent  8533cc275ece6d551c9d7b81e5fa4d9d24e03157
xl: print sxp on dry-run of create.

The help text for xm create's --dry-run says "Dry run - prints the
resulting configuration in SXP but does not create the domain." so
update xl implementation to match. At least the xendomains initscript
relies on this (for better or worse).

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Tested-by: Carsten Schiers <carsten@xxxxxxxxxx>

diff -r 8533cc275ece -r 064a0d9f710a tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Wed Jun 01 13:47:47 2011 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Wed Jun 01 13:51:34 2011 +0100
@@ -1503,10 +1503,6 @@ static int create_domain(struct domain_c
     parse_config_data(config_file, config_data, config_len, &d_config, 
-    ret = 0;
-    if (dom_info->dryrun)
-        goto out;
     if (migrate_fd >= 0) {
         if (d_config.c_info.name) {
             /* when we receive a domain we get its name from the config
@@ -1525,9 +1521,13 @@ static int create_domain(struct domain_c
-    if (debug)
+    if (debug || dom_info->dryrun)
         printf_info(-1, &d_config, &d_config.dm_info);
+    ret = 0;
+    if (dom_info->dryrun)
+        goto out;
     domid = -1;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>