This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] rombios: correct $PIR table router device ID

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] rombios: correct $PIR table router device ID
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Tue, 31 May 2011 14:55:17 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Tue, 31 May 2011 06:56:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.6.4
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1306850100 -3600
# Node ID 0d66c300e9f759f2829230941eb93a4d957a2fe2
# Parent  ae85ab56e17d0bad84dabfe65b5d730a6ba1d431
rombios: correct $PIR table router device ID.

Currently the $PIR table embedded in ROMBIOS refers to a "compatible PCI
Interrupt Router" with Vendor/Device ID 8086:122e (Intel 82371FB, Original
PIIX, I think), despite the fact that the Xen ioemu appears AFAICT to have
never provided this particular device.

Both the current qemu-xen and upstream qemu trees provide a device with ID
8086:1237 (Intel 82441, i440FX chipset) so switch to using this.

Prior to 18931:0a393ba0ec0a the $PIR refered to an 8086:7000 (Intel 82371SB,
PIIX3), which again AFAICT nothing ever provided...

I've no idea which OSes actually pay attention to $PIR (Windows 98 perhaps?)
and I certainly don't know what behaviour either the old/wrong or the
new/"correct" value for this field will provoke. There's a strong arugment to
be made for leaving well enough alone...

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r ae85ab56e17d -r 0d66c300e9f7 tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Tue May 31 12:11:34 2011 +0100
+++ b/tools/firmware/rombios/rombios.c  Tue May 31 14:55:00 2011 +0100
@@ -9936,7 +9936,7 @@ pci_routing_table_structure:
   db 0x08 ;; PCI interrupt router DevFunc
   dw 0x0000 ;; PCI exclusive IRQs
   dw 0x8086 ;; compatible PCI interrupt router vendor ID
-  dw 0x122e ;; compatible PCI interrupt router device ID
+  dw 0x1237 ;; compatible PCI interrupt router device ID
   dw 0,0 ;; Miniport data
   db 0,0,0,0,0,0,0,0,0,0,0 ;; reserved
   db 0x37 ;; checksum

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>