WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] mem_event: Allow memory access listener to perfo

To: Keir Fraser <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] mem_event: Allow memory access listener to perform single step execution
From: Aravindh Puthiyaparambil <aravindh@xxxxxxxxxxxx>
Date: Sat, 28 May 2011 10:48:18 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Delivery-date: Sat, 28 May 2011 10:49:16 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuata.com; s=google; h=domainkey-signature:mime-version:x-originating-ip:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=GPujTVXKD1zcDeq6IKhhPdu54xDJH2wAI9kTw9cjCCA=; b=eVMJ/sa8D36I3G1XPoUIgfO21qf2H8dm7c5eN4njJ0zoXX7oHfz0vlJChkAEP0nG1N l/22boUS+tU0MlkbjuSkJz54BNU6w8ZEczZhagFCRWyGYRB9AejgMBNs54dj4/bDLkpi FwcKizstsaUC8cms9ypnYrSyXiqNE6xp+vUxs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=virtuata.com; s=google; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=2dbcnDJ1R/Pw157v39LUge/Xin98kIHSQ1FU5HmbDrLeJA8w1SvAuilY05dEQ6qQx1 PHzD1dLqfPcRBPR20UFBFHz/Mj8FqpDiizNBOr08RCuPQAtAjZQNdLjwn6X0q74MJj4f UBxOZJ60BMeHihNa17Z8jhGHVMp/OLb5KMzoc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CA0668A4.2E036%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTinycxFpscdxS+C57=QhPjbuP184CQ@xxxxxxxxxxxxxx> <CA0668A4.2E036%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, May 28, 2011 at 12:53 AM, Keir Fraser <keir@xxxxxxx> wrote:
> I removed and unrelated and pointless change that broke the x86_32 build, as
> c/s 23435. If that change is okay for you, I could backport the combination
> of 23434+23435 to 4.1.1.

Keir,

Sorry about the build breakage. I will test the 32-bit side of things
also in the future.

I did not realize VCPU pausing was nestable. So even after the
vcpu_unpause() in hvm_debug_op(), the VCPU will still be paused
because of the vcpu_pause() in p2m_mem_access_check()? If that is the
case I am fine with the combination for 4.1.1.

Thanks,
Aravindh

>  -- Keir
>
> On 27/05/2011 17:36, "Aravindh Puthiyaparambil" <aravindh@xxxxxxxxxxxx>
> wrote:
>
>> Can this be included in xen-4.1-testing.hg too so that it could make the Xen
>> 4.1.1 cut?
>>
>> Thanks,
>> Aravindh
>>
>> On May 27, 2011 1:39 AM, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
>>> At 04:39 +0100 on 27 May (1306471145), Aravindh Puthiyaparambil wrote:
>>>> mem_event: Allow memory access listener to perform single step execution.
>>>> Add a new memory event that handles single step. This allows the memory
>>>> access listener to handle instructions that modify data within the 
>>>> execution
>>>> page.
>>>> This can be enabled in the listener by doing:
>>>> xc_set_hvm_param(xch, domain_id, HVM_PARAM_MEMORY_EVENT_SINGLE_STEP,
>>>> HVMPME_mode_sync)
>>>>
>>>> Now the listener can start single stepping by:
>>>> xc_domain_debug_control(xch, domain_id, XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_ON,
>>>> vcpu_id)
>>>>
>>>> And stop single stepping by:
>>>> xc_domain_debug_control(xch, domain_id, 
>>>> XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_OFF,
>>>> vcpu_id)
>>>>
>>>> Signed-off-by: Aravindh Puthiyaparambil <aravindh@xxxxxxxxxxxx>
>>>
>>> Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>>>
>>> --
>>> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>>> Principal Software Engineer, Xen Platform Team
>>> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel