WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network device c

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network device creation with upstream qemu [and 1 more messages]
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Thu, 26 May 2011 15:40:54 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 07:41:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19934.26090.743074.960987@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <6b1fe0cba8a2f0bcc127.1306311646@xxxxxxxxxxxxxxxxxxxxxxxxx> <m38vtun7wh.fsf@xxxxxxxxxxxxxxxxxxxxx> <19934.26090.743074.960987@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-05-26 at 15:38 +0100, Ian Jackson wrote:
> Markus Armbruster writes ("Re: [Xen-devel] [PATCH] libxl: use preferred 
> syntax for network device creation with upstream qemu"):
> > I figure this is a good idea.
> 
> Thanks, I'll take that as an ack.
> 
> However, sorry to nitpic, but:
> 
> Ian Campbell writes ("[Xen-devel] [PATCH] libxl: use preferred syntax for 
> network device creation with upstream qemu"):
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "nic,vlan=%d,macaddr=%s,model=%s",
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "tap,vlan=%d,ifname=%s,script=%s",
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "%s,netdev=net%d,mac=%s",
> > +                                                         vifs[i].model, 
> > vifs[i].devid, smac));
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "type=tap,id=net%d,ifname=%s,script=%s",
> 
> This increases the number of overly-long lines.  It's very hard to
> read on my screen:

I noticed that and fixed it in the replacement patch, see
<1306399985.775.22.camel@xxxxxxxxxxxxxxxxxxxxxx>

> 
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "nic,vlan=%d,ma
> caddr=%s,model=%s",
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "tap,vlan=%d,if
> name=%s,script=%s",
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "%s,netdev=net%
> d,mac=%s",
> > +                                                         vifs[i].model, 
> > vifs
> [i].devid, smac));
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "type=tap,id=ne
> t%d,ifname=%s,script=%s",
> 
> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel