Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network

On Thu, 2011-05-26 at 15:38 +0100, Ian Jackson wrote:
> Markus Armbruster writes ("Re: [Xen-devel] [PATCH] libxl: use preferred 
> syntax for network device creation with upstream qemu"):
> > I figure this is a good idea.
> 
> Thanks, I'll take that as an ack.
> 
> However, sorry to nitpic, but:
> 
> Ian Campbell writes ("[Xen-devel] [PATCH] libxl: use preferred syntax for 
> network device creation with upstream qemu"):
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "nic,vlan=%d,macaddr=%s,model=%s",
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "tap,vlan=%d,ifname=%s,script=%s",
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "%s,netdev=net%d,mac=%s",
> > +                                                         vifs[i].model, 
> > vifs[i].devid, smac));
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "type=tap,id=net%d,ifname=%s,script=%s",
> 
> This increases the number of overly-long lines.  It's very hard to
> read on my screen:

I noticed that and fixed it in the replacement patch, see
<1306399985.775.22.camel@xxxxxxxxxxxxxxxxxxxxxx>

> 
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "nic,vlan=%d,ma
> caddr=%s,model=%s",
> > -                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "tap,vlan=%d,if
> name=%s,script=%s",
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "%s,netdev=net%
> d,mac=%s",
> > +                                                         vifs[i].model, 
> > vifs
> [i].devid, smac));
> > +                flexarray_append(dm_args, libxl__sprintf(gc, 
> > "type=tap,id=ne
> t%d,ifname=%s,script=%s",
> 
> Ian.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network device creation with upstream qemu [and 1 more messages], Ian Jackson

Next by Date:

AW: [Xen-devel] Re: Patch and question about init.d, Ian Jackson

Previous by Thread:

Re: [Xen-devel] [PATCH] libxl: use preferred syntax for network device creation with upstream qemu [and 1 more messages], Ian Jackson

Next by Thread:

[Xen-devel] libxl: setmaxmem functionality?, Markus Groß

Indexes:

[Date] [Thread] [Top] [All Lists]