This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create

To: Carsten Schiers <carsten@xxxxxxxxxx>
Subject: AW: Re: AW: [Xen-devel] Possible Compatibility Bug in xl create
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 26 May 2011 15:31:19 +0100
Cc: "Ian.Campbell" <Ian.Campbell@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Stefano.Stabellini" <Stefano.Stabellini@xxxxxxxxxxxxx>, fantonifabio <fantonifabio@xxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 07:31:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <H0000067000adfc8.1306350444.uhura.space.zz@MHS>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <H0000067000adfc4.1306349236.uhura.space.zz@MHS> <H0000067000adfc8.1306350444.uhura.space.zz@MHS>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Carsten Schiers writes ("AW: Re: AW: [Xen-devel] Possible Compatibility Bug in 
xl create"):
> Crosscheck: renamed
>   domain_create_info -> create_info_domain  
>   domain_build_info -> build_info_domain 
>   domid (in three device blocks) -> devdomid
> in tools/libxl/xl_cmdimpl.c and everything works as expected with 
> my /etc/default/xendomains, which ist shutting down and restarting 
> from /etc/xen/auto only.

Would you care to send a patch to the "printf (blah blah)" output ?

The only purpose for that code is for compatibility for situations
exactly like yours and we should make it work like it used to.

Please ensure to add a Signed-off-by line to your patch to signify
its copyright status (see below).


>From Documentation/SubmittingPatches in the Linux kernel tree:
        Developer's Certificate of Origin 1.1
        By making a contribution to this project, I certify that:
        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or
        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or
        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

Xen-devel mailing list