WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Play with spice for xen-upstream-qemu on upstrea

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Play with spice for xen-upstream-qemu on upstream Xen
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Thu, 26 May 2011 22:07:09 +0800
Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 07:10:46 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qfv3UJEQC7+XGvOlnt31CRV7vGrJH2NdDEADY8m3gUk=; b=hzBpLP5ieH0gP/lybq6uwlGbdRw7fRyZVi1lpjf2CjwpzOkZ7nvXv031VdAU4GQYoc fMxaqmkj1IY5brgzeGtTLrVON0N2rlpeViWVHiOzFL0k2wGGSGpKft6kOc3Nf/ycY0lh rPL99aKcR9WA9S2j1X3/+k3u9nt+YirMwYLE4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QImGBmbVPuhqUM5vQkBQD9oh6M5u4jibdxyPVlJyJtcamngFdNj47mo5ldiaFcQlng iMKkb6ZD6rpdkCbxNjYqlMXRWp3Kz/6iyHOQ8D8sZqPPwhfFAKuG4qDMplyhHZVbek5G g/AoQY6G96gDxbUZ9yqy7XUDgUYKUN7ZknmIM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19934.22336.520004.747016@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTi=9OBXN0fMaPEvrEityAqM-L6yPBQ@xxxxxxxxxxxxxx> <19884.26020.847575.426352@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTik5EKzCwFdV1D5w9wt1Gu6XZ4N4MA@xxxxxxxxxxxxxx> <19926.34224.455450.51781@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTi=Dg_QQsa1b4Pin3RxYmoF=nFyk6A@xxxxxxxxxxxxxx> <BANLkTi=QGPb8eBcgp4qZvEwNVJkKybcxSA@xxxxxxxxxxxxxx> <19931.54520.528337.70653@xxxxxxxxxxxxxxxxxxxxxxxx> <BANLkTim0bGgem1UR8HvmFLAw7BajYsok6A@xxxxxxxxxxxxxx> <19934.22236.921974.790867@xxxxxxxxxxxxxxxxxxxxxxxx> <19934.22336.520004.747016@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
It's fine.
Thanks

2011/5/26 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> I wrote:
>> Yes, I agree.  I will make this change myself as it's just one
>> character :-).  Thanks for digging.
>
> Ian.
>
> # HG changeset patch
> # User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> # Date 1306416939 -3600
> # Node ID 240bdcce0ad2e0caa0fa9ee6448952239a219ab0
> # Parent  d8d24e8a81f8413eb25b14984f69d0e39e63eb3a
> libxl: add missing ":" in log messages
>
> libxl__logv would fail to put a ":" between the function name and the
> rest of the message.
>
> Reported-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>
> diff -r d8d24e8a81f8 -r 240bdcce0ad2 tools/libxl/libxl_internal.c
> --- a/tools/libxl/libxl_internal.c      Thu May 26 14:33:52 2011 +0100
> +++ b/tools/libxl/libxl_internal.c      Thu May 26 14:35:39 2011 +0100
> @@ -168,7 +168,7 @@ void libxl__logv(libxl_ctx *ctx, xentool
>  x:
>     xtl_log(ctx->lg, msglevel, errnoval, "libxl",
>             "%s%s%s%s" "%s",
> -            fileline, func&&file?":":"", func?func:"", func||file?" ":"",
> +            fileline, func&&file?":":"", func?func:"", func||file?": ":"",
>             base);
>     if (base != enomem) free(base);
>     errno = esave;
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel