WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Wei Liu <liuw@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection
From: Keir Fraser <keir@xxxxxxx>
Date: Thu, 26 May 2011 10:10:51 +0100
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 26 May 2011 02:12:04 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=N5gKyOnw18FQTobSa02Fw4LA5mArbdiIjF2sFURI9Lk=; b=rpCGcd9qEfxfCS5J7sSll+A75tZyWqMsQBJD3ZGtstCQuolvpcP9FucDbMT+Skttwj ivAY3lMzBu2BjjVyPzqUmZ2f5j8kqjGANxOlNbtATkkaUPv10U8bGneWTSVH1SVL62Uv jXwC5s8/rlGyNDpVog6ngkfr3OUD0NESxM0ag=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=A1mLjXTeqS5DqFuW7qrIcTqRQvoahXBRN51DVeSUdnFATQBnDhQdtg1cH2gM3S1eOv Tgz9fvpOf2H9g5CvuU2hV9NKORkRgH1RTWug7VMv6lurYJ1biVBn0ip8Xx/96eH2EL4u a2DkFDfid653YPmRkdd2jMx2IsCZ/VzqsLIrk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110526084331.GB9790@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwbhM8IkiXR7a0kS06ryku0hiC+QA==
Thread-topic: [Xen-devel] [PATCH 1/2] Xen: enabling emulated MSI injection
User-agent: Microsoft-Entourage/12.29.0.110113
On 26/05/2011 09:43, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

>> +/* MSI injection for emulated devices */
>> +#define HVMOP_inj_msi         16
>> +struct xen_hvm_inj_msi {
>> +    /* Domain to be injected */
>> +    domid_t   domid;
>> +    /* Address (0xfeeXXXXX) */
>> +    uint64_t  addr;
>> +    /* Data -- lower 32 bits */
>> +    uint32_t  data;
>> +};
> 
> Please rearrange this so that it has the same size and layout on 32-bit
> and 64-bit builds.

You can do this most easily be simply swapping the second and third fields.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel