This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/2] x86: Enabling emulated MSI injection

To: Wei Liu <liuw@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] x86: Enabling emulated MSI injection
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Thu, 26 May 2011 05:49:38 +0100
Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 25 May 2011 21:50:40 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=5n6Li9cqMG+AbDdzoRUiLbv7YI1fsJIqrDKQuqa+/p8=; b=aYQS8qu/s/kHdiZJg57WiELvXuKlAmkzrG8HqiRv4g0joR108baaHi+gmmiMlA6MzW 7+GZOChYhCCYwBwCVvGkJ8U2kl/H3oD3qDRCgvjCJyP5RPt8W7eJ7H3i4XAFi1JWs4VP rnl9rXqFQsuPKqvoAyPmunx2j/T/V7BZs82bw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=pO2xYkC47sUFAv2wZ/HE9st50r82/wOO7Sqd7wLyP6yzsxiaMsw1Lp24muWz4QfEhF RP4NCCmfMInAbbZhLDpj7Ouuzghcb9q+CvemRbRXYf15mhv885PpJPPPNPVMuYFZ/NvV faZaEFn3LjdvvBehuskZpK9A129iD5PV8uxFs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTi=xxx3jCHGOVFCTT73GqHbG-K1CCA@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwbYFEyY5dP+n7QT06ZGlCUgjFJHA==
Thread-topic: [Xen-devel] [PATCH 0/2] x86: Enabling emulated MSI injection
User-agent: Microsoft-Entourage/
On 26/05/2011 04:06, "Wei Liu" <liuw@xxxxxxxxx> wrote:

> This patch series enables Xen to deliver emulated MSI for upstream QEMU.
> To achieve this goal, a new HVM operation -- HVMOP_inj_msi -- is
> added. Also the VMSI handling code for x86 is refactored. Libxc is
> modified as well.
> Tested with VirtIO net and VirtIO disk.
> Signed-off-by: Wei Liu <liuw@xxxxxxxxx>

Don't renumber existing HVMOPs, some of the numbers are baked into our guest
ABI. Define your new HVMOP at the end, and enclose in if defined(__XEN__) ||
defined(__XEN_TOOLS__) -- it is only used by toolstack (qemu) and this gives
us flexibility to change your new interface in future if we need to, as this
tells us it is not baked into the guest ABI.

Apart from that, collect an Ack from Stefano that this integrates okay with
his pirq/emuirq stuff for delivering HVM interrupts on event channels. It
may be that you're going in at a slightly too raw level. Stefano wrote a
bunch of the pirq stuff so he can advise on that.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>