Re: [Xen-devel] [PATCH] [PATCH v2] build: Don't fetch tools/ioem

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] [PATCH v2] build: Don't fetch tools/ioemu-dir unless needed
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Tue, 24 May 2011 19:00:40 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 24 May 2011 11:03:18 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=QZCtpBZpYXk84sbmciP2dqv8SScq4hW2RIPb0WDBu3Q=; b=ggEm5k3tRI4xMODWbZwipzXZQ5Iet/nt8FrLq8scDJZQpOn1nx4xnT7nK5NYY+NkA6 P+cBMZvGvd9DZ5rOnwkrl1e8W4tNSi+Ma9Ov3rEEHVUFD5mQd6NisXhgl+3p6yh5Ol2r 1ikK5DDJpIMqQb7ulBswV7R5NLpeZ132GeDl4=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=qaTA+CBvgzZjt58d7sAoKq1kOB0+0yLUar4a9aPugi9vpkrkZlMeLtGxhWt9ZFhHbu EhZ7xXPACHoK9ZRCu04o5wAZFShrVlNRn1/gBONcAO3IwmXBsruZ30PSAAvb+proEK/h uoL0lmbR0C/2+5xLMSg5laLa/zJTd5k8L4hSE=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19931.55748.735156.96897@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcwaPH3tlOPMtSgooUmIrT9GNvkQWg==
Thread-topic:	[Xen-devel] [PATCH] [PATCH v2] build: Don't fetch tools/ioemu-dir unless needed
User-agent:	Microsoft-Entourage/12.29.0.110113

On 24/05/2011 17:16, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> George Dunlap writes ("[Xen-devel] [PATCH] [PATCH v2] build: Don't fetch
> tools/ioemu-dir unless needed"):
>> c/s 18482 made both stubdom and tools dependent on tools/ioemu-dir
>> to fix a race condition where both build paths might try to fetch
>> qemu in parallel.  But this means that even if you build the tools
>> with CONFIG_IOEMU=n, qemu is still fetched first.
> 
> This seems to conflict with 0e9322ece398, which is also a patch of
> yours to do apparently the same thing.  Was that an earlier version ?
> Am I just behind the times ?  There may have been discussion of this
> on the list, that I missed, in which case sorry ....

I picked up George's patch and 'reinterpreted' it.

 -- Keir

> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] [PATCH v2] build: Don't fetch tools/ioemu-dir un