This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [PATCH] Re: [Xen-devel] Re: [Pkg-xen-devel] xen 4.1 blktap2 support

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] Re: [Pkg-xen-devel] xen 4.1 blktap2 support
From: Ian Campbell <ijc@xxxxxxxxxxxxxx>
Date: Mon, 23 May 2011 10:47:53 +0100
Cc: Bastian Blank <waldi@xxxxxxxxxx>, "pkg-xen-devel@xxxxxxxxxxxxxxxxxxxxxxx" <pkg-xen-devel@xxxxxxxxxxxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 23 May 2011 02:49:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19926.40957.888651.17404@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4DB82B38.6090207@xxxxxxxxx> <BAY148-w56B2B88110870F89DE84D4EF980@xxxxxxx> <4DB89A39.6070203@xxxxxxxxx> <BAY148-w282F83283CEBAD8F438117EF9B0@xxxxxxx> <4DB91947.2070203@xxxxxxxxx> <1303977639.25988.1447.camel@xxxxxxxxxxxxxxxxxxxxx> <20110428110658.GA26816@xxxxxxxxxxxxxxxxxxxxxxx> <1303990128.25988.1570.camel@xxxxxxxxxxxxxxxxxxxxx> <20110428122719.GA27897@xxxxxxxxxxxxxxxxxxxxxxx> <1304000458.25988.1731.camel@xxxxxxxxxxxxxxxxxxxxx> <20110429110808.GA14859@xxxxxxxxxxxxxxxxxxxxxxx> <1304597864.26692.79.camel@xxxxxxxxxxxxxxxxxxxxxx> <19926.40957.888651.17404@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-05-20 at 18:08 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] Re: [Xen-devel] Re: [Pkg-xen-devel] xen 4.1 
> blktap2 support"):
> > Agreed, and anyway libxl_exec is a generic is supposed to be a generic
> > interface so having it close file handles which the caller _wants_ to
> > pass to the child is a bit unhelpful.
> > 
> > Lets try the below to start with.
> It looks good but you are missing some #includes I think:
> cc1: warnings being treated as errors
> libxl_exec.c: In function 'check_open_fds':
> libxl_exec.c:56: error: implicit declaration of function 'fcntl'
> libxl_exec.c:56: error: 'F_GETFD' undeclared (first use in this function)
> libxl_exec.c:56: error: (Each undeclared identifier is reported only once
> libxl_exec.c:56: error: for each function it appears in.)
> libxl_exec.c:64: error: 'FD_CLOEXEC' undeclared (first use in this function)

fcntl(2) says fcntl needs unistd.h (already present in source) and
fcntl.h (added by this patch). Did a hunk get rejected? I'm build
testing on Squeeze.

> libxl_exec.c: In function 'libxl__spawn_spawn':
> libxl_exec.c:175: error: 'pipes' undeclared (first use in this function)
> make: *** [libxl_exec.o] Error 1

pipes is a local variable added by this patch which should have been
reference several times by line 175... Another .rej?

Ian Campbell

The world really isn't any worse.  It's just that the news coverage
is so much better.

Xen-devel mailing list