This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH 24 of 45] gcc-4.6 compile fix: xen/arch/x86/msi.c

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 24 of 45] gcc-4.6 compile fix: xen/arch/x86/msi.c
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 19 May 2011 21:05:43 +0200
Delivery-date: Thu, 19 May 2011 12:29:43 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1305832170; l=1137; s=domk; d=aepfle.de; h=To:From:Date:References:In-Reply-To:Subject: Content-Transfer-Encoding:MIME-Version:Content-Type:X-RZG-CLASS-ID: X-RZG-AUTH; bh=0nZ2OiLUqOSzvAg1487LFwCjtts=; b=NZjpon1WYnOr6sNyfZ0DDcNIdbilBwMYeMJSGecP4xM3RwUeNuORcx4QqtReuRoe0hc 7FqnFlocsi7uXo79UHXFe9IggHI5cYWXy+oaB1mf7OCAnrYkyoC8HHINkjGfMk+JLPJLl rwfPGyDt96+/ndmjGM6mT65X1n5F+BA62o0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1305831919@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1305831919@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.7.5
# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1305824409 -7200
# Node ID d657cd6182d517b8b5e0fffb0f34ea451f49c916
# Parent  452ca03a71814742f94213554399f6cfbf350046
gcc-4.6 compile fix: xen/arch/x86/msi.c

msi.c: In function '__pci_disable_msi':
msi.c:749:9: error: variable 'control' set but not used 

(Is this a dummy read before doing the disable?)

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r 452ca03a7181 -r d657cd6182d5 xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Thu May 19 19:00:08 2011 +0200
+++ b/xen/arch/x86/msi.c        Thu May 19 19:00:09 2011 +0200
@@ -745,17 +745,8 @@ static int __pci_enable_msi(struct msi_i
 static void __pci_disable_msi(struct msi_desc *entry)
     struct pci_dev *dev;
-    int pos;
-    u16 control;
-    u8 bus, slot, func;
     dev = entry->dev;
-    bus = dev->bus;
-    slot = PCI_SLOT(dev->devfn);
-    func = PCI_FUNC(dev->devfn);
-    pos = pci_find_cap_offset(bus, slot, func, PCI_CAP_ID_MSI);
-    control = pci_conf_read16(bus, slot, func, msi_control_reg(pos));
     msi_set_enable(dev, 0);

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>