WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] retry instruction on svm emulation failure

To: Paolo Bonzini <pbonzini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] retry instruction on svm emulation failure
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 18 May 2011 11:08:30 +0100
Cc:
Delivery-date: Wed, 18 May 2011 03:09:14 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=/k/1VeE4GWzHVf5JT6IgZWs6vO+OlR61y6tCVXYPNk8=; b=rbq3i5tT7ugSssJdzSUQfcexJepPVhyrbpilfKbQEXBV6HnQISSvFklzc2nxDoKdfc d5qSW8NqjE5Xj836aQPvdDyek6fSi517ZyCK1jjnVaKDy8iRJwhylV5CALWwAwKekjTw mk1aCKV6Qkq6yqkUPpHJRKjzpKhMbz1RjO5fo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=Ya8tqXq4rU5GZrHOKSz/xQmilVMSEZAwlHFQlsf6Oj1eJJ/w4Bo2rqYCp2QUdLRpIR KV4Bs7v32EEns4Ru/uZVs1iERUJ0SgEZ6qAgMcTUzC5P660UzepxpiQWzrKJXzbm66mP qIjrWIy0qUztb4pwp1i+JUGj0cYBUn2o31Lps=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <8605c877b972c82a3859.1305708728@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwVQ4l0LtJ7aJ3Wt0+LxRzhx+QAkg==
Thread-topic: [Xen-devel] [PATCH] retry instruction on svm emulation failure
User-agent: Microsoft-Entourage/12.29.0.110113
On 18/05/2011 10:05, "Paolo Bonzini" <pbonzini@xxxxxxxxxx> wrote:

> retry instruction on svm emulation failure
> 
> Upon emulation failure, Xen injects a #GP into the guest on AMD machines.
> However, this kind of #GP does not happen in hardware.  It is possible
> (and was observed in practice) that the failure is transient.  It will
> go away naturally if the instruction is retried, because the guest will
> be executing other code and will not exit.

It begs the question why we were emulating the instruction in the first
place. I'd like to see further explanation, with a concrete example, before
applying this patch. Or get an Ack from an AMD maintainer.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>