This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from

To: Daniel Kiper <dkiper@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from online_page()
From: David Rientjes <rientjes@xxxxxxxxxx>
Date: Thu, 12 May 2011 12:26:22 -0700 (PDT)
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, dave@xxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, andi.kleen@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, wdauchy@xxxxxxxxx
Delivery-date: Thu, 12 May 2011 12:27:27 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1305228395; bh=OGwx3D/kBF5VOxnqhkpIx1C7K4Y=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=rGt4DRS1PbT60L5TPAqDv3+uLtdbFsXENVvS9z5gA7xch7ULy6Z+rPUbgx1WQVeLy 2d3O7HVw2/83+A0mKAr8Q==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:date:from:x-x-sender:to:cc:subject:in-reply-to :message-id:references:user-agent:mime-version:content-type; bh=ms0258MdS3zEufd1eVmORLDnz/GdZ59yE7vbvqXA/80=; b=YULRSjYJ6Ng5Smx2tFx2WC5kSFMWpRwJt7K4RUjjAcFv/uP/6kY2084ylX7gCNw59e ValjLQLiTi4V1r9PXhkw==
Domainkey-signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=B8OZq8tpHZoAzDWDNOTfPZ92OWwejaJn0hfZtqFcDFwY/zJFm1px9daG+Kd7PbtbDs H2XKtGtiyf9WVeXegOog==
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110512102515.GA27851@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110502211915.GB4623@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1105111547160.24003@xxxxxxxxxxxxxxxxxxxxxxxxx> <20110512102515.GA27851@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 12 May 2011, Daniel Kiper wrote:

> > > Memory hotplug code strictly depends on CONFIG_SPARSEMEM.
> > > It means that code depending on CONFIG_FLATMEM in online_page()
> > > is never compiled. Remove it because it is not needed anymore.
> > >
> > > Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>
> >
> > The code you're patching depends on CONFIG_MEMORY_HOTPLUG_SPARSE, so this
> > is valid.  The changelog should be updated to reflect that, however.
> >
> > Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
> No problem, however, this bundle of patches was added to the -mm tree.
> In this situation should I repost whole bundle with relevant changes
> or post only those two patches requested by you ??? For which tree
> should I prepare new version of patches ???

No, I would just reply to the email notification you received when the 
patch went into -mm saying that the changelog should be adjusted to read 
something like

        online_pages() is only compiled for CONFIG_MEMORY_HOTPLUG_SPARSE,
        so there is no need to support CONFIG_FLATMEM code within it.

        This patch removes code that is never used.

Xen-devel mailing list