WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/3] hvm: vpmu: Add support for AMD Family 15h p

To: Jacob Shin <jacob.shin@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/3] hvm: vpmu: Add support for AMD Family 15h processors
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Tue, 10 May 2011 18:20:44 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 10 May 2011 10:21:26 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=r4ZenycI8A8NpwoPGJNbuZJqy0JKarNbeVwECA/bg10=; b=vHfxMXsBZLEn91BWVwXM/tdQHrLAWX9EP5hSs7tgPI15p8RL8Bdt6uvCBUfpsD+MXL Fsx/4o+fGT38s/nI5e5cbnzYMDhmH7iEPF0Clgmq59cwnHVOrCQARs4LeNwQmd/F2HIu YZEOxn9zYdFHi6Idyh5opWFm1uIg/3yGaRnIE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=cEOGuKMnSrnk6Tl+bL2UqqYhgZyCL+MT00Sc6/N3o6lCiQF0lyZny1AxRgbjrpgI17 i0ebYi5gT6xMRJOpFEmu8PHRXX01UpYo23tcFffo9IulgZdpFfJa+8Ri+fYUhIRGb5vP mLAgyODq4iE+7YipVSvuVeb+Xc1LOIOPPNY88=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DC96F18.7030406@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwPNpgEOBRgZ9P+/0e8GAGwNmgl5A==
Thread-topic: [Xen-devel] [PATCH 3/3] hvm: vpmu: Add support for AMD Family 15h processors
User-agent: Microsoft-Entourage/12.29.0.110113
On 10/05/2011 18:00, "Jacob Shin" <jacob.shin@xxxxxxx> wrote:

> On 05/05/2011 02:43 AM, Jan Beulich wrote:
>>>>> On 05.05.11 at 03:09, Jacob Shin<jacob.shin@xxxxxxx>  wrote:
>>> --- a/xen/arch/x86/hvm/vpmu.c Wed May 04 10:56:36 2011 -0500
>>> +++ b/xen/arch/x86/hvm/vpmu.c Wed May 04 19:17:59 2011 -0500
>>> @@ -101,6 +101,7 @@ void vpmu_initialise(struct vcpu *v)
>>>           switch ( family )
>>>           {
>>>           case 0x10:
>>> +        case 0x15:
>>>               vpmu->arch_vpmu_ops =&amd_vpmu_ops;
>>>               break;
>>>           default:
>> 
>> How about 0x11, 0x12, and 0x14?
>> 
> 
> Family 11h does not have guest only event monitoring .. but yes, we can
> enable 12h and 14h in the same path as the 10h. I'll send out a revised
> patchset later this afternoon.

I already applied your patch series (with MSRs renamed as Jan recommended).
So just send the above as a delta patch please.

 -- Keir

> Thanks!
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/x


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel