This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain ar

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 04 May 2011 21:37:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Allen M Kay <allen.m.kay@xxxxxxxxx>
Delivery-date: Wed, 04 May 2011 13:38:51 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=AbhZHHHhM72JGkEIvoNFY03Uu5Jcm13Z0z1WB3F248Y=; b=vbp2NAj/hgIL5atjiOGX3bkKqmCZZktIVvq7/QOig54Qkw8ZlFv5Wzs/mO1ZFg7vqk DIKULRuwCqj+wg4tbsu1/f9RsJTBdIpzGdBS3JuwdJkxQJgO33qrqn01y2W7LqM1DmCi 4cPIm0kHqpO02N0dzKxFc3xEfWEa/+3v/0cT4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=U5hnT0nFbxfLW88LrIFIMX+rO+pPKlLRFdXJOEdoCdUGO4WTl5NypcJwe1nEBf/If5 S+wcB6QRU3mQcnRc4/gA2nVBFR5nrEVvtjbAJuyKiod0Z3O1oWwliSp0jHZZXEXFZoBw JTbxXnk8TWMzF/QiCYt7i/VJ4424/f0SGGFoE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9E76DA6.1740F%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwKlSe8ZV2u+ZRfoUGwKEbo8U7M3AABfvVU
Thread-topic: [Xen-devel] [PATCH 1/2, v2] x86: replace nr_irqs sized per-domain arrays with radix trees
User-agent: Microsoft-Entourage/
On 04/05/2011 20:55, "Keir Fraser" <keir.xen@xxxxxxxxx> wrote:

>> Ideally, the Xen radix-tree.c would support both needs through some
>> kind of layering, but if your preference is to go to the upstream
>> Linux radix-tree.c, I can probably leverage my inlined-radix-tree
>> code into Xen tmem.c.  I don't expect it will be trivial though.
> I'm sure I can pull in upstream radix-tree.c and get Xen's tmem ported onto
> it. As for performance, I may leave the tagging stuff out as we won't need
> it. Then it's just quibbling over RCU overheads, which I would bet are
> manageable. We can modify radix-tree.c further if there is good reason for
> it.

Looking at 2.6.38's radix-tree implementation, I'll be stripping it down
heavily as I pull it in. It will likely be acceptable enough for tmem as is
after that, else after only minor further changes.

 -- Keir

Xen-devel mailing list