On 03.05.2011 17:40, Konrad Rzeszutek Wilk wrote:
> On Mon, May 02, 2011 at 01:06:19PM +0200, Marek Marczykowski wrote:
>> barrier variable is int, not long. This overflow caused another variable
>> override: "err" (in PV code) and "binfo" (in xenlinux code -
>> drivers/xen/blkfront/blkfront.c). The later caused incorrect device
>> flags (RO/removable etc).
>
> Weird, I get this:
>
> konrad@phenom:~/work/linux$ patch -p1 < ~/for-40-blkfront
> patching file drivers/block/xen-blkfront.c
> patch: **** malformed patch at line 124: *info)
>
> Any ideas?
Ehh... my email client wrapped this line...
> Can you send the patch as attachment please?
Sure, attached.
>> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
>> ---
>> drivers/block/xen-blkfront.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index 70f3b1b..6147a4e 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
>> *info)
>> }
>>
>> err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
>> - "feature-barrier", "%lu", &barrier,
>> + "feature-barrier", "%d", &barrier,
>> NULL);
>>
>> /*
>>
>
>
>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>
--
Pozdrawiam / Best Regards,
Marek Marczykowski | RLU #390519
marmarek at mimuw edu pl | xmpp:marmarek at staszic waw pl
0001-blkfront-fix-data-size-for-xenbus_gather-in-blkfront.patch
Description: Text document
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home