WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH][VTD] force boot to fail if interrupt remapping c

To: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][VTD] force boot to fail if interrupt remapping cannot be enabled when iommu=force
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Thu, 28 Apr 2011 18:05:03 +0100
Cc: "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Thu, 28 Apr 2011 10:06:05 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=YD8IA8HHw8DhWdhj0HGBy+WtD5hk5ljaNgiNb2oLwpQ=; b=LGgtT7HBxL53GpkBuzWtFCyyIgtyRtpKY6j1AmcIl/Ss873OlZp3TdPemQ66D2BauJ grvJUgCIrp89SvgeoTvXIoHZhAIuq37XBsYK5jUDQtyv2lalPKKPfR+UWs6NC/XyetCO F5ro+2OGiC+CzdHLcQAbh+P39SJL9oQJ3vK88=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=V77tQIoW/4agQ8qflOMgBt2nH/rmgljUhatbf9b2jqihZu1zIv+eEDIaLVr5D2Pf9g ggrgYYHXCkgU4XgdCeIKnkEh8e0EmitB6ghrja71jPCK2PlwK7p1r6k+I+6Y9useGoE2 GEY3c4GP9KasWMNI/g0346lRd1pUXsZ8uYP1M=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <987664A83D2D224EAE907B061CE93D5301C51BE9D8@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwFNNYW4YeEKo21TgqWL8v00UgwwAAkZQZ1
Thread-topic: [PATCH][VTD] force boot to fail if interrupt remapping cannot be enabled when iommu=force
User-agent: Microsoft-Entourage/12.29.0.110113
On 28/04/2011 00:42, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:

> Force Xen boot to fail if interrupt remapping fails to enable and the
> following are true: iommu=force is set as xen boot parameter, VT-d engine HW
> is interrupt remapping capable, DMAR_INTR_REMAP bit is set in DMAR flags.
> This forces iommu=force boot instances has interrupt remapping enabled if HW
> and BIOS supports it.

If HW and BIOS support it, why would it fail to be enabled? This doesn't
look like a particularly useful panic() path. If interrupt remapping is so
important, perhaps iommu=force should unconditionally require it, and panic
in its absence regardless of platform features? As it is, this looks like a
panic that is never realistically going to trigger.

 -- Keir

> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel