This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] hotplug: fix busy loop device detection

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] hotplug: fix busy loop device detection
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 28 Apr 2011 16:54:58 +0200
Delivery-date: Thu, 28 Apr 2011 07:55:52 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1304002499; l=1410; s=domk; d=aepfle.de; h=Content-Type:MIME-Version:Subject:To:From:Date:X-RZG-CLASS-ID: X-RZG-AUTH; bh=g6p39rsfdppPef54rtExItJKLRo=; b=gMzZKiyQJGMBBPeQ/3qplMN/KTlrER6vnDYGr7Mouz+KNGl+oUXsa1i6BvFdMO1obT5 9gtCPxG20HIxAZBKHMbqpbyem0KNG0OpWlElo8SfmTqhRt7VhZWo3yAoaFM2ybVxIvULc 3OtifX01HhRl74LkT98W8o2p95llmYx4pIU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
Improve busy loop device detection after changeset 22773:02c0af2bf280

The intention is not to find the file to be mounted in the losetup -a
output.  What matters are existing mounted files with the same dev:inode
as the new file.  So the fix is to apply variable expansion which
happens only without double quotes.  Otherwise $dev will contain
newlines for hardlinked files, as mentioned in the commit message from
the changeset above.

losetup -a does also truncate long filenames to 62 chars due to ioctl
limitations.  This part is fixed with 2.6.37 where the filename can be
obtained from sysfs. As a result very long filenames will be missed.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

 tools/hotplug/Linux/block |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: xen-unstable.hg-4.2.23282/tools/hotplug/Linux/block
--- xen-unstable.hg-4.2.23282.orig/tools/hotplug/Linux/block
+++ xen-unstable.hg-4.2.23282/tools/hotplug/Linux/block
@@ -280,8 +280,8 @@ mount it read-write in a guest domain."
           shared_list=$(losetup -a |
-                sed -n -e 
"s@^\([^:]\+\)\(:[[:blank:]]\[${dev}\]:${inode}[[:blank:]](${file})\)@\1@p" )
-          for dev in "$shared_list"
+                sed -n -e 
"s@^\([^:]\+\)\(:[[:blank:]]\[${dev}\]:${inode}[[:blank:]](.*)\)@\1@p" )
+          for dev in $shared_list
             if [ -n "$dev" ]

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] hotplug: fix busy loop device detection, Olaf Hering <=