WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH v6] xen pci backend driver.

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH v6] xen pci backend driver.
From: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Date: Mon, 25 Apr 2011 11:58:50 -0700
Cc: linux-pci@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, konrad@xxxxxxxxxx
Delivery-date: Mon, 25 Apr 2011 12:01:13 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org; h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=fiA2HHSlxeSOVylkX3W8EbgXtiZW1Y3NsMrUP9MXxh100Kgti5HRgXku5Tz/WSMJCAO/uKLX01+ytwKy/xKX4S2oCI7wGxtNRHUIl+TCQTvt06Cc4A+5okmjXE1gjLSl;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1303333640-5994-1-git-send-email-konrad.wilk@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1303333640-5994-1-git-send-email-konrad.wilk@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 20 Apr 2011 17:07:19 -0400
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> The following patch implements the Xen pci backend for upstream Linux.
> This is the host side counterpart to the frontend driver in
> drivers/pci/xen-pcifront.c. The PV protocol is also implemented by
> frontend drivers in other OSes too, such as the BSDs.
> 
> This driver has a long history as an out of tree driver but I am
> submitting it here as a single monolithic patch to aid review. Once it
> has been reviewed and is considered suitable for merging can we perhaps
> consider merging the equivalent git branch which maintains much of
> history?

It looks pretty clean at first glance (though 128k worth of patch isn't
an ideal way to split it).

But maybe the back end belongs in arch/x86/xen as it's really a arch
specific PCI implementation at heart?  I don't want to be a bottleneck
for any Xen specific PCI patches in the future, and other arches have a
similar split (though not always with an ideal core vs arch split).

Figuring out some way to preserve the git history is probably a good
idea, assuming it's not too much of a mess.  If it is, a more
reasonable split and history using rebase could probably be contrived
before merging it.

-- 
Jesse Barnes, Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>