This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] tools: hvmloader: attempt to SHUTDOWN_crash on B

To: Ian Campbell <ian.campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: hvmloader: attempt to SHUTDOWN_crash on BUG
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 20 Apr 2011 18:24:27 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Apr 2011 10:26:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <05abea47f4dc670974cd.1303143712@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <05abea47f4dc670974cd.1303143712@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ian Campbell writes ("[Xen-devel] [PATCH] tools: hvmloader: attempt to 
SHUTDOWN_crash on BUG"):
> tools: hvmloader: attempt to SHUTDOWN_crash on BUG
> If we have got as far as having enabled hypercalls then this signals to the
> toolstack that something went wrong. Otherwise they tend to assume the guest
> has either shutdown or rebooted which can lead to simply trying again
> repeatedly.

Surely in principle this is wrong.  Anything other than a deliberate
decision by hvmloader to exit cleanly (how would that ever happen?)
should be treated as a crash.

Perhaps the toolstack for an hvm domain should set the shutdown reason
to "crashed" before unpausing ?  It looks like this is possible with
an appropriate domctl ...


Xen-devel mailing list