This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 13 Apr 2011 15:20:21 +0200
Cc: Keir Fraser <keir.xen@xxxxxxxxx>
Delivery-date: Wed, 13 Apr 2011 06:21:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9CB5E73.1644B%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C9CB5E73.1644B%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote:
> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Cleanup for ASID emulation:
> > - Use C99 integer types for asid numbers
> >
> > - asid.c: consistently use 'v' instead of 'curr'
> On what planet is that an improvement??
> We use 'curr' as a convenient idiom to represent cached current. Whereas
> 'v' is supposed to represent an arbitrary vcpu.

Oh, that's the difference. I thought 'curr' is just another random name for an 
arbitrary vcpu.

I will resend the patch w/o that hunk.

> I know it costs three extra characters per use, but it does make code
> easier to understand.
>  -- Keir
> > - Introduce svm_invlpga() used in ASID emulation patch
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list