This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0 of 7] libxl: refactor tap disk handling

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 7] libxl: refactor tap disk handling
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 7 Apr 2011 14:31:45 +0200
Delivery-date: Thu, 07 Apr 2011 05:39:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1302169946@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1302169946@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv: Gecko/20110202 Lightning/1.0b3pre Thunderbird/3.1.7
On 04/07/11 11:52, Ian Campbell wrote:
I'm not personally convinced that support for blktap2 devices should
be conflated in libxl with the PV block backend support but given it's
there lets at least correct it.

In a blktap2 system there is no "tap" PV backend type. blktap2 exposes
a standard block device and this is passed to a guest using the
standard blkback "vbd" (sometimes called "phy") backend. Drop the
"tap" backend type and associated (libxl internal ) DEVICE_TAP
enumeration value.

What happens on a no-blktap2 system?

Also try and clarify the paths which fallback from blktap2 to qdisk
when the former is not present. Falling through a switch statement is
a neat way of doing this in some cases, but I don't think this is one
of them.

Xen-devel mailing list

---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list