This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: fix hypervisor crash with xentrace
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Wed, 06 Apr 2011 16:01:08 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 06 Apr 2011 08:01:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D9C7A56.8070007@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201104061632.02099.Christoph.Egger@xxxxxxx> <4D9C7A56.8070007@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 06.04.11 at 16:36, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
> On 04/06/11 16:32, Christoph Egger wrote:
>> Hi,
>> Attached patch fixes hypervisor crashes when xentrace buffer gets 
> initialized.
> Forgot to mention this regression was introduced in c/s 
> 23134:f5d33782a57b by Jan Beulich.

But just removing the __init-s isn't the right way to fix this (Did
you notice the comment in register_cpu_notifier(), which I also
pointed out in the changeset description). Apparently I overlooked
a call to register_cpu_notifier(), and it's that which ought to get
moved into an __init function.


Xen-devel mailing list