This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][VTD] check BIOS settings before enabling interru

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Allen M Kay <allen.m.kay@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][VTD] check BIOS settings before enabling interrupt remapping or x2apic
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 06 Apr 2011 08:40:03 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 06 Apr 2011 00:41:15 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=HQAtIzwesiOilZ7AOTMcCbN48tumYt9y6bJ2WDwj3oY=; b=ss6y0y0SrVcn0Xqqce2NO+EJqR9SQfumdizaPgikjd7Ehmiu2doCk+pa2ATWZ2aAKq 6N1CPEK/UqgWefceAaWxpbaNFx+4pnuHkLz2ueuucXLySNLM/bI1MyioOkPiKcKchBkz eawE6slmY4g852VqqKGj2TimQAA90sJ5WQf4A=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=JB0lr1tar/yxnU/c/njmgFqDToHEFLhN2+3NpQNsQD7A3b4lEI7b8Sfs+jpkijcwa/ 1dM5VOSwxDiKVFY2c0mBc7gHKll+NGL+y4eCiYHAISCcRVrIh3mlrEQ8lV16YHSzsCXm HKJ6Lj1hbMnSmQrndhlj8j+vkJRqsy9f/uHLg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D9C26B2020000780003A1CB@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acv0LdcenT/K0dfNtES8NB/MFvWzIg==
Thread-topic: [PATCH][VTD] check BIOS settings before enabling interrupt remapping or x2apic
User-agent: Microsoft-Entourage/
On 06/04/2011 07:39, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> On 05.04.11 at 20:10, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>> Removed __init modifier for platform_supports_intremap() and
>> platform_supports_x2apic().
> Sorry, but removing the __init from just the definitions isn't sufficient
> (normally the declarations shouldn't have these added, but as you
> did they'll need to be removed there too).

I'll fix this and apply the patch.


> Jan
>> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
>> -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
>> Sent: Tuesday, April 05, 2011 3:53 AM
>> To: Kay, Allen M
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Keir Fraser
>> Subject: Re: [PATCH][VTD] check BIOS settings before enabling interrupt
>> remapping or x2apic
>>>>> On 29.03.11 at 19:58, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
>>> Check flags field in ACPI DMAR structure before enabling interrupt remapping
>>> or x2apic.  This allows platform vendors to disable interrupt remapping or
>>> x2apic features if on board BIOS does not support them.
>>> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
>> Marking platform_supports_intremap() and platform_supports_x2apic()
>> __init isn't correct - both get called from the resume path.
>> Jan

Xen-devel mailing list