Re: [Xen-devel] [PATCH 3 of 7] xenpaging: remove srand call

[Patrick Colp <pjcolp@xxxxxxxxx>]

On 31 March 2011 10:36, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1301591570 -7200
> # Node ID cd35892de8ff2388aa46e3768393f217a3c63521
> # Parent  a811d86a48f400cd541500e0e6ae765fdcd02ef9
> xenpaging: remove srand call
>
> The policy uses now a linear algorithm instead of picking random gfn
> numbers.  Remove the call to srand().

Is a linear algorithm better than random?


Patrick


>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> diff -r a811d86a48f4 -r cd35892de8ff tools/xenpaging/xenpaging.c
> --- a/tools/xenpaging/xenpaging.c       Thu Mar 31 19:11:57 2011 +0200
> +++ b/tools/xenpaging/xenpaging.c       Thu Mar 31 19:12:50 2011 +0200
> @@ -544,9 +544,6 @@
>     domain_id = atoi(argv[1]);
>     num_pages = atoi(argv[2]);
>
> -    /* Seed random-number generator */
> -    srand(time(NULL));
> -
>     /* Initialise domain paging */
>     paging = xenpaging_init(domain_id);
>     if ( paging == NULL )
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel