This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 00 of 14] Improvements to libxl VIF hotplug and o

To: Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 00 of 14] Improvements to libxl VIF hotplug and ocaml bindings (v2)
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 31 Mar 2011 09:36:43 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 31 Mar 2011 01:37:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1301508321@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1301508321@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-03-30 at 19:05 +0100, Dave Scott wrote:
> Improvements to libxl VIF hotplug/unplug and ocaml bindings; xapi can now use 
> these functions
> This patch set includes:
> 1. addition of VIF QoS parameters to libxl (this code is ported from xapi/
>    xenops)
> 2. updates to the libxl ocaml bindings to make them more usable and more
>    easily generatable from the IDL
> 3. bugfixes to the "xl network-attach" command so the QoS settings can be
>    more easily tested.
> FYI the corresponding xapi changes are in a branch here:
> https://github.com/djs55/xen-api/tree/hackathon

Not up to date with the latest API changes? I'm just curious how this
ends up looking on the user side.

I already acked 1 and 14/14. 2-12/14 all seem pretty mechanical. I
suspect I will need to tweak things as I autogenerate things (esp. the
build info tagged union stuff) but lets cross that bridge when we get
there. On that basis 2-12 are all:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

14/14 I already acked so that just leaves 13/14 -- see you over there in
a moment ;-)


> Changes since the last submission include:
> * updating the whole ocaml xl module to use the new style for consistency
> * some dead ocaml functions were removed
> * documentation for the QoS parameters added to the libxl IDL
> * the QoS parameter was renamed to have "kb" rather than "kib" for consistency
> Signed-off-by: David Scott <dave.scott@xxxxxxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list