WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform

To: Alexander Graf <agraf@xxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V11 06/15] xen: Add the Xen platform pci device
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Mon, 28 Mar 2011 17:08:00 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, QEMU-devel <qemu-devel@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 28 Mar 2011 09:16:28 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=7qZtIszYk/mXskgU7LpWIxrafVQ771yEagU5+gpEvcw=; b=Jjn+ibafl76sPXJADq8htXz601S3mFVLWVBrJfksGt6arllOo6mk+mBfKdDFtoHQhw AS6CLVIvYCrXnL89fjFtnVHztkAiCsJiN6wS/7MuJAGJJBTv+N5N/iz1cEINM92Pt/sN 76YQsdakYgnNL8n9Hxpnan6mGyb/lRsoebSQo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=XqH4SqhUO43wcROairYVhDKUKl4CpGBzpl5l0dxaozowWME1ulMKS8nqD+gVPUwn1A dKfDntCIu2ryidxsHccufBTpx1hNtw1haRrcPFlxTGhhNZMQ0w964PckLHQdBkM2+rKa EaJiTJfZ6c3MEJGjH+L1g1KEz13JaC/KkhCR0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <D10F331E-FD1E-435B-AE57-96794C402C8C@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1299004529-31290-1-git-send-email-anthony.perard@xxxxxxxxxx> <1299004529-31290-7-git-send-email-anthony.perard@xxxxxxxxxx> <D10F331E-FD1E-435B-AE57-96794C402C8C@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, Mar 23, 2011 at 12:08, Alexander Graf <agraf@xxxxxxx> wrote:
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index 6eff06e..417c456 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -121,6 +121,10 @@ static void pc_init1(ram_addr_t ram_size,
>>
>>     pc_vga_init(pci_enabled? pci_bus: NULL);
>>
>> +    if (xen_enabled()) {
>> +        pci_xen_platform_init(pci_bus);
>
> It probably makes sense to fold that function in here. That way you wouldn't 
> need the entry in the stub file.

Yes, I will do that.

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>