This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] xen kernel headers: circular dependencies

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] xen kernel headers: circular dependencies
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Mon, 28 Mar 2011 11:56:42 +0200
Delivery-date: Mon, 28 Mar 2011 03:10:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv: Gecko/20110202 Lightning/1.0b3pre Thunderbird/3.1.7


I just uncovered a circular header dependency starting from

_PAGE_NX is defined in asm-x86/x86_{64,32}/page.h and uses cpu_has_nx
cpu_has_nx is defined in asm-x86/cpufeature.h.

So make asm-x86/x86_{64,32}/page.h include <asm/cpufeature.h>

cpufeature.h uses boot_cpu_data which is declared in asm-x86/processor.h

So make cpufeature.h include <asm/processor.h>

processor.h uses NCAPINTS which is defined in cpufeature.h

processor.h already includes cpufeature.h

gcc fails to build with complaining about implicit declaration of function 'get_cpu_info' then.

Any suggestions on how to fix this?


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>