This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] x86: cleanup after tboot fix (c/s 23101:dd386a4b6595

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: cleanup after tboot fix (c/s 23101:dd386a4b6595)
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Mon, 28 Mar 2011 08:00:28 +0100
Delivery-date: Mon, 28 Mar 2011 00:00:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
When submitting the patch that became 23101:dd386a4b6595 I forgot that
I actually intended to remove the pointless IRQ disabling and restoring
(and the then pointless comment). Pointless because the code, other
than its pre-23013:65d26504e843 original, now runs before interrupts
get enabled for the first time.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/drivers/passthrough/vtd/dmar.c
+++ b/xen/drivers/passthrough/vtd/dmar.c
@@ -761,12 +761,7 @@ out:
 int __init acpi_dmar_init(void)
-    unsigned long flags;
-    /* Disabling IRQs avoids cross-CPU TLB flush in map_pages_to_xen(). */
-    local_irq_save(flags);
     acpi_get_table(ACPI_SIG_DMAR, 0, &dmar_table);
-    local_irq_restore(flags);
     return parse_dmar_table(acpi_parse_dmar);

Attachment: acpi-tboot-cleanup-23101.patch
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86: cleanup after tboot fix (c/s 23101:dd386a4b6595), Jan Beulich <=