This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: WARNING: at kernel/timer.c:1012 del_timer_sync+0x39/0x4e

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: [Xen-devel] Re: WARNING: at kernel/timer.c:1012 del_timer_sync+0x39/0x4e()
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 25 Mar 2011 14:01:10 +0000
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 25 Mar 2011 07:02:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D8C9004.6080804@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D8C8A6F.6090208@xxxxxxxx> <4D8C9004.6080804@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9
On 03/25/2011 12:52 PM, Jens Axboe wrote:
>> How should this be fixed? Is this call to blk_stop_queue() bogus, or is
>> it OK to call it in a handler like this?  If so, is the warning itself
>> wrong?
> Calling it in there should be fine, the problem is that the work cancel
> turns into a sync timer delete. That is not needed. Can you try the
> below?

Yep, that works.  Tested-by: Jeremy Fitzhardinge

>> Does this relate to  7eaceaccab5f4 "block: remove per-queue plugging"?
> No

OK.  Is the correct fix for that change to just remove all the
plug/unplug code?  We have some still out-of-tree code that stopped


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>